walterddr commented on a change in pull request #7607: [FLINK-10076][table] 
Upgrade Calcite dependency to 1.18
URL: https://github.com/apache/flink/pull/7607#discussion_r252786140
 
 

 ##########
 File path: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/table/OverWindowTest.scala
 ##########
 @@ -53,20 +54,20 @@ class OverWindowTest extends TableTestBase {
           unaryNode(
             "DataStreamCalc",
             streamTableNode(0),
-            term("select", "a", "b", "c", "proctime")
+            term("select", "a", "b", "c", "proctime", "1 AS $4")
 
 Review comment:
   due to "[CALCITE-2726] RexSimplify does not simplify enough for some of the 
nested operations, doesn't do nested visitCall". this looks like something we 
have to fix on Calcite side. do you think we can proceed with this test change 
and later fix it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to