walterddr commented on a change in pull request #7607: [FLINK-10076][table]
Upgrade Calcite dependency to 1.18
URL: https://github.com/apache/flink/pull/7607#discussion_r252764493
##########
File path: flink-libraries/flink-table/pom.xml
##########
@@ -96,25 +96,12 @@ under the License.
<groupId>org.apache.calcite</groupId>
<artifactId>calcite-core</artifactId>
<!-- When updating the Calcite version, make sure to
update the dependency exclusions -->
- <version>1.17.0</version>
+ <version>1.18.0</version>
<exclusions>
- <!-- Dependencies that are not needed for how
we use Calcite right now -->
<exclusion>
<groupId>org.apache.calcite.avatica</groupId>
<artifactId>avatica-metrics</artifactId>
</exclusion>
- <exclusion>
Review comment:
I did some experiments and seems like Calcite 1.18 has dependencies on
`com.fastjackson.core` and `core.fastjackson.databind` that cannot be ignored.
I will try to push a fix. but in general, do you think we should somehow shade
calcite to avoid pulling in jackson directly into flink-table? (The answer
might be different if we first pull in #7587 like @zentol suggested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
