walterddr commented on a change in pull request #7607: [FLINK-10076][table] 
Upgrade Calcite dependency to 1.18
URL: https://github.com/apache/flink/pull/7607#discussion_r252765823
 
 

 ##########
 File path: 
flink-libraries/flink-table/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java
 ##########
 @@ -5129,6 +5129,11 @@ private SqlNode navigationInDefine(SqlNode node, String 
alpha) {
 
        public void validateAggregateParams(SqlCall aggCall, SqlNode filter,
                SqlValidatorScope scope) {
+               validateAggregateParams(aggCall, filter, null, scope);
 
 Review comment:
   there are more changes in this class. I will recopy the file from new 
release. thanks for the check, I wasn't aware we always need to keep them in 
sync.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to