walterddr commented on a change in pull request #7607: [FLINK-10076][table] 
Upgrade Calcite dependency to 1.18
URL: https://github.com/apache/flink/pull/7607#discussion_r253316402
 
 

 ##########
 File path: 
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java
 ##########
 @@ -229,7 +229,6 @@ public void testCompleteStatement() throws Exception {
                final SessionContext session = new 
SessionContext("test-session", new Environment());
 
                final List<String> expectedTableHints = Arrays.asList(
-                       "TABLE",
 
 Review comment:
   This is removed due to the new `SqlAdvisor` now does not default ignore case 
when matches hints. alternative option is to pass in the ParserConfig to the 
SqlAdvisor - But the ParserConfig also has ignoreCase set to false, which is 
confusing to me why this test allows "TABLE" in the first place.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to