tillrohrmann commented on a change in pull request #6898: [FLINK-10431]
Extraction of scheduling-related code from SlotPool into preliminary Scheduler
URL: https://github.com/apache/flink/pull/6898#discussion_r227448691
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/Scheduler.java
##########
@@ -172,8 +172,8 @@ else if (ret instanceof CompletableFuture) {
}
@Override
- public CompletableFuture<Acknowledge> cancelSlotRequest(SlotRequestId
slotRequestId, @Nullable SlotSharingGroupId slotSharingGroupId, Throwable
cause) {
- return CompletableFuture.completedFuture(Acknowledge.get());
+ public Acknowledge cancelSlotRequest(SlotRequestId slotRequestId,
@Nullable SlotSharingGroupId slotSharingGroupId, Throwable cause) {
Review comment:
I guess it could have a `void` return type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
