tillrohrmann commented on a change in pull request #6898: [FLINK-10431] Extraction of scheduling-related code from SlotPool into preliminary Scheduler URL: https://github.com/apache/flink/pull/6898#discussion_r227447242
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java ########## @@ -1676,6 +1684,35 @@ public void updateAccumulators(AccumulatorSnapshot accumulatorSnapshot) { } } + /** + * Computes and returns a set with the prior allocation ids from all execution vertices in the graph. + */ + private Set<AllocationID> computeAllPriorAllocationIds() { + HashSet<AllocationID> allPreviousAllocationIds = new HashSet<>(); + Iterable<ExecutionJobVertex> ejvIterable = getVerticesTopologically(); + for (ExecutionJobVertex executionJobVertex : ejvIterable) { + for (ExecutionVertex executionVertex : executionJobVertex.getTaskVertices()) { Review comment: `getAllExecutionVertices` should be easier to use here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services