tillrohrmann commented on a change in pull request #6898: [FLINK-10431] Extraction of scheduling-related code from SlotPool into preliminary Scheduler URL: https://github.com/apache/flink/pull/6898#discussion_r227450833
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DefaultSchedulerFactory.java ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.jobmaster.slotpool; + +import org.apache.flink.configuration.CheckpointingOptions; +import org.apache.flink.configuration.Configuration; + +import javax.annotation.Nonnull; + +import java.util.HashMap; + +/** + * Default implementation of a {@link SchedulerFactory}. + */ +public class DefaultSchedulerFactory implements SchedulerFactory { + + @Nonnull + private final SlotSelectionStrategy slotSelectionStrategy; + + public DefaultSchedulerFactory(@Nonnull SlotSelectionStrategy slotSelectionStrategy) { + this.slotSelectionStrategy = slotSelectionStrategy; + } + + @Nonnull + @Override + public Scheduler createScheduler(@Nonnull SlotPoolGateway slotPoolGateway) { + return new Scheduler(new HashMap<>(), slotSelectionStrategy, slotPoolGateway); Review comment: What could be a reasonable initial size of the `HashMap`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
