tillrohrmann commented on a change in pull request #6898: [FLINK-10431]
Extraction of scheduling-related code from SlotPool into preliminary Scheduler
URL: https://github.com/apache/flink/pull/6898#discussion_r227872948
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotProvider.java
##########
@@ -90,7 +90,7 @@
* @param cause of the cancellation
* @return Future which is completed once the slot request has been
cancelled
*/
- CompletableFuture<Acknowledge> cancelSlotRequest(
+ Acknowledge cancelSlotRequest(
Review comment:
Can this become `void`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
