tillrohrmann commented on a change in pull request #6898: [FLINK-10431]
Extraction of scheduling-related code from SlotPool into preliminary Scheduler
URL: https://github.com/apache/flink/pull/6898#discussion_r227450350
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/AllocatedSlotActions.java
##########
@@ -39,10 +38,23 @@
* @param slotRequestId identifying the slot to release
* @param slotSharingGroupId identifying the slot sharing group to
which the slot belongs, null if none
* @param cause of the slot release, null if none
- * @return Acknowledge (future) after the slot has been released
+ * @return Acknowledge after the slot has been released
*/
- CompletableFuture<Acknowledge> releaseSlot(
+ @Deprecated
+ Acknowledge releaseSlot(
Review comment:
Could be `void`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
