Dandandan commented on code in PR #16083: URL: https://github.com/apache/datafusion/pull/16083#discussion_r2118781458
########## datafusion/physical-plan/src/joins/utils.rs: ########## @@ -975,6 +996,12 @@ pub(crate) fn adjust_indices_by_join_type( // the left_indices will not be used later for the `right anti` join Ok((left_indices, right_indices)) } + JoinType::RightMark => { + let right_indices = get_mark_indices(&adjust_range, &right_indices); + let left_indices = + UInt64Array::from_iter_values(adjust_range.map(|i| i as u64)); Review Comment: it's faster to collect into a Vec -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org