ctsk commented on code in PR #16083:
URL: https://github.com/apache/datafusion/pull/16083#discussion_r2139507808
##########
datafusion/optimizer/src/optimize_projections/mod.rs:
##########
@@ -704,7 +704,8 @@ fn split_join_requirements(
| JoinType::Left
| JoinType::Right
| JoinType::Full
- | JoinType::LeftMark => {
+ | JoinType::LeftMark
+ | JoinType::RightMark => {
Review Comment:
I admit that I don't understand why LeftMark/RightMark are different from
their Semi/Anti counterparts. It seems like the documentation of this method is
missing LeftMark / RightMark too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
