jonathanc-n commented on code in PR #16083:
URL: https://github.com/apache/datafusion/pull/16083#discussion_r2119682441
##########
datafusion/sql/src/unparser/plan.rs:
##########
@@ -738,21 +739,38 @@ impl Unparser<'_> {
let negated = match join.join_type {
JoinType::LeftSemi
| JoinType::RightSemi
- | JoinType::LeftMark => false,
+ | JoinType::LeftMark
+ | JoinType::RightMark => false,
JoinType::LeftAnti | JoinType::RightAnti => true,
_ => unreachable!(),
};
let exists_expr = ast::Expr::Exists {
subquery: Box::new(query_builder.build()?),
negated,
};
- if join.join_type == JoinType::LeftMark {
- let (table_ref, _) =
right_plan.schema().qualified_field(0);
- let column = self
- .col_to_sql(&Column::new(table_ref.cloned(),
"mark"))?;
- select.replace_mark(&column, &exists_expr);
- } else {
- select.selection(Some(exists_expr));
+
+ match join.join_type {
+ JoinType::LeftMark => {
Review Comment:
Refactored to be:
```
JoinType::LeftMark | JoinType::RightMark => {
let source_schema = if join.join_type == JoinType::LeftMark {
left_plan.schema()
} else {
right_plan.schema()
};
let (table_ref, _) = source_schema.qualified_field(0);
let column = self.col_to_sql(&Column::new(table_ref.cloned(), "mark"))?;
select.replace_mark(&column, &exists_expr);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
