jonathanc-n commented on code in PR #16083:
URL: https://github.com/apache/datafusion/pull/16083#discussion_r2119831572
##########
datafusion/physical-plan/src/joins/utils.rs:
##########
@@ -1126,6 +1153,28 @@ where
.collect()
}
+pub(crate) fn get_mark_indices<T: ArrowPrimitiveType>(
+ range: &Range<usize>,
+ input_indices: &PrimitiveArray<T>,
+) -> PrimitiveArray<UInt32Type>
+where
+ NativeAdapter<T>: From<<T as ArrowPrimitiveType>::Native>,
+{
+ let mut builder = PrimitiveBuilder::<UInt32Type>::new();
+
+ for idx in range.clone() {
+ let matched = input_indices.iter().flatten().any(|v| v.as_usize() ==
idx);
Review Comment:
Fixed, thanks @ctsk!
##########
datafusion/physical-plan/src/joins/sort_merge_join.rs:
##########
@@ -221,9 +221,11 @@ impl SortMergeJoinExec {
// When output schema contains only the right side, probe side is
right.
// Otherwise probe side is the left side.
match join_type {
- JoinType::Right | JoinType::RightSemi | JoinType::RightAnti => {
- JoinSide::Right
- }
+ // TODO: sort merge support for right mark
Review Comment:
Tracked at #16226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
