westhide commented on code in PR #1212:
URL:
https://github.com/apache/datafusion-ballista/pull/1212#discussion_r2020090087
##########
ballista/scheduler/src/scheduler_server/grpc.rs:
##########
@@ -124,14 +128,36 @@ impl<T: 'static + AsLogicalPlan, U: 'static +
AsExecutionPlan> SchedulerGrpc
};
let mut tasks = vec![];
+ let mut prepare_failed_jobs = HashMap::<String,
Vec<TaskDescription>>::new();
for (_, task) in schedulable_tasks {
- match self.state.task_manager.prepare_task_definition(task) {
+ let job_id = task.partition.job_id.clone();
+ if prepare_failed_jobs.contains_key(&job_id) {
+ prepare_failed_jobs.entry(job_id).or_default().push(task);
+ continue;
+ }
+ match self
+ .state
+ .task_manager
+ .prepare_task_definition(task.clone())
+ {
Ok(task_definition) => tasks.push(task_definition),
Err(e) => {
error!("Error preparing task definition: {:?}", e);
+
prepare_failed_jobs.entry(job_id).or_default().push(task);
}
}
}
+
+ unbind_prepare_failed_tasks(active_jobs,
&prepare_failed_jobs).await;
Review Comment:
FYI
### Scheduler get `running_tasks` by `filter_map` Some(task_info)
https://github.com/apache/datafusion-ballista/blob/9f8e4fcbefb5580fa0f93e6899ae99733a67b055/ballista/scheduler/src/state/execution_graph/execution_stage.rs#L587-L599
### Scheduler Send `CancelTasks` event to Executor
https://github.com/apache/datafusion-ballista/blob/9f8e4fcbefb5580fa0f93e6899ae99733a67b055/ballista/scheduler/src/scheduler_server/query_stage_scheduler.rs#L232-L251
### Executor log `error!("Error cancelling task: {:?}", e);` if
`cancel_tasks` fail
https://github.com/apache/datafusion-ballista/blob/9f8e4fcbefb5580fa0f93e6899ae99733a67b055/ballista/executor/src/executor_server.rs#L706-L732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
