milenkovicm commented on code in PR #1212:
URL:
https://github.com/apache/datafusion-ballista/pull/1212#discussion_r2020249569
##########
ballista/scheduler/src/scheduler_server/grpc.rs:
##########
@@ -125,10 +125,15 @@ impl<T: 'static + AsLogicalPlan, U: 'static +
AsExecutionPlan> SchedulerGrpc
let mut tasks = vec![];
for (_, task) in schedulable_tasks {
+ let job_id = task.partition.job_id.clone();
match self.state.task_manager.prepare_task_definition(task) {
Ok(task_definition) => tasks.push(task_definition),
Err(e) => {
error!("Error preparing task definition: {:?}", e);
+ info!("Cancel prepare task definition failed job: {}",
job_id);
+ if let Err(err) = self.cancel_job(job_id).await {
Review Comment:
Would it be better if we fail job instead of canceling it
`QueryStageSchedulerEvent::JobRunningFailed {...}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
