milenkovicm commented on code in PR #1212:
URL:
https://github.com/apache/datafusion-ballista/pull/1212#discussion_r2020224499
##########
ballista/scheduler/src/state/task_manager.rs:
##########
@@ -524,24 +524,35 @@ impl<T: 'static + AsLogicalPlan, U: 'static +
AsExecutionPlan> TaskManager<T, U>
pub(crate) async fn launch_multi_task(
&self,
executor: &ExecutorMetadata,
- tasks: Vec<Vec<TaskDescription>>,
+ tasks: HashMap<(String, usize), Vec<TaskDescription>>,
executor_manager: &ExecutorManager,
- ) -> Result<()> {
+ ) -> Result<HashMap<String, Vec<TaskDescription>>> {
Review Comment:
not sure what would be better approach, do propagate the sender as parameter
and cancel job or to return job_ids which tasks failed. anyway it does not look
like we need to return anything but hash set failed job_is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
