milenkovicm commented on code in PR #1212:
URL: 
https://github.com/apache/datafusion-ballista/pull/1212#discussion_r2020223746


##########
ballista/scheduler/src/state/mod.rs:
##########
@@ -248,7 +262,7 @@ impl<T: 'static + AsLogicalPlan, U: 'static + 
AsExecutionPlan> SchedulerState<T,
     async fn launch_tasks(

Review Comment:
   I wonder if it makes sense to propagate 
`sender:EventSender<QueryStageSchedulerEvent>,` and 
`task.manager.launch_multi_task` and cancel the jobs there?
   
   `task.manager.launch_multi_task` semantics is not clean, do yield error if 
only one task fail?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to