Spaarsh commented on code in PR #1059:
URL:
https://github.com/apache/datafusion-python/pull/1059#discussion_r1991599117
##########
python/tests/test_wrapper_coverage.py:
##########
@@ -51,6 +58,8 @@ def missing_exports(internal_obj, wrapped_obj) -> None:
if isinstance(internal_attr, list):
assert isinstance(wrapped_attr, list)
for val in internal_attr:
+ if isinstance(val, str) and val.startswith("Raw"):
+ continue
Review Comment:
This is more cohesive and well-structured, I have already ran the Ci test
for this locally and it works, will push it if you approve this:
```
for attr in dir(internal_obj):
if attr in ["_global_ctx"] or attr.startswith("Raw"): #<---Skip Raw
classes for now
continue
[...]
if isinstance(internal_attr, list):
assert isinstance(wrapped_attr, list)
for val in internal_attr:
if isinstance(val, str) and val.startswith("Raw"):
#<---check for Raw classes and their corresponding wrapper classes here
# Check if Raw* classes have corresponding wrapper
classes
wrapper_class = val[3:] # Remove "Raw" prefix
assert hasattr(wrapped_obj, wrapper_class), f"Missing
wrapper class: {wrapper_class} for Raw class: {val}"
continue
assert val in wrapped_attr
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
