timsaucer commented on code in PR #1059: URL: https://github.com/apache/datafusion-python/pull/1059#discussion_r1991610394
########## python/tests/test_wrapper_coverage.py: ########## @@ -51,6 +58,8 @@ def missing_exports(internal_obj, wrapped_obj) -> None: if isinstance(internal_attr, list): assert isinstance(wrapped_attr, list) for val in internal_attr: + if isinstance(val, str) and val.startswith("Raw"): + continue Review Comment: When you say that you tested it locally and it works, have you verified that it also fails when it is supposed to fail? I won't have time to review this again today, but I hope to get to it tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org