timsaucer commented on code in PR #1059:
URL:
https://github.com/apache/datafusion-python/pull/1059#discussion_r1990118259
##########
python/tests/test_wrapper_coverage.py:
##########
@@ -36,7 +36,12 @@ def missing_exports(internal_obj, wrapped_obj) -> None:
for attr in dir(internal_obj):
if attr in ["_global_ctx"]:
continue
- assert attr in dir(wrapped_obj)
+
Review Comment:
If you apply ruff it should correct these whitespace errors. I recommend
turning on pre-commit in your local workspace to catch them before they get to
CI.
##########
python/datafusion/expr.py:
##########
@@ -102,6 +102,7 @@
__all__ = [
"Expr",
+ "RawExpr",
Review Comment:
To remove.
##########
python/tests/test_wrapper_coverage.py:
##########
@@ -36,7 +36,12 @@ def missing_exports(internal_obj, wrapped_obj) -> None:
for attr in dir(internal_obj):
if attr in ["_global_ctx"]:
continue
- assert attr in dir(wrapped_obj)
Review Comment:
Why remove this assert?
##########
python/datafusion/expr.py:
##########
@@ -193,10 +194,15 @@ class Expr:
:ref:`Expressions` in the online documentation for more information.
"""
- def __init__(self, expr: expr_internal.Expr) -> None:
+ def __init__(self, expr: expr_internal.RawExpr) -> None:
"""This constructor should not be called by the end user."""
self.expr = expr
+ @property
+ def raw_expr(self) -> expr_internal.RawExpr:
Review Comment:
I don't think we need this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
