Spaarsh commented on code in PR #1059:
URL:
https://github.com/apache/datafusion-python/pull/1059#discussion_r1991565666
##########
python/tests/test_wrapper_coverage.py:
##########
@@ -51,6 +58,8 @@ def missing_exports(internal_obj, wrapped_obj) -> None:
if isinstance(internal_attr, list):
assert isinstance(wrapped_attr, list)
for val in internal_attr:
+ if isinstance(val, str) and val.startswith("Raw"):
+ continue
Review Comment:
The 'RawExpr' isn't in `__all__` as you had suggested not to in the comment
[here](https://github.com/apache/datafusion-python/pull/1059#discussion_r1990116848).
So now the `isinstance` block only checks for the `non-raw` classes,
essentially the wrapper classes like `Expr`.
> Possibly I need to document all of the reasons for the portions of that
test.
That would be helpful. I've added comments next to the new sections as well.
##########
python/tests/test_wrapper_coverage.py:
##########
@@ -51,6 +58,8 @@ def missing_exports(internal_obj, wrapped_obj) -> None:
if isinstance(internal_attr, list):
assert isinstance(wrapped_attr, list)
for val in internal_attr:
+ if isinstance(val, str) and val.startswith("Raw"):
+ continue
Review Comment:
The 'RawExpr' isn't in `__all__` as you had suggested not to in the comment
[here](https://github.com/apache/datafusion-python/pull/1059#discussion_r1990116848).
So now the `isinstance` block only checks for the `non-raw` classes,
essentially the wrapper classes like `Expr`.
> Possibly I need to document all of the reasons for the portions of that
test.
That would be helpful. I've added comments next to the new sections as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
