timsaucer commented on code in PR #1059:
URL:
https://github.com/apache/datafusion-python/pull/1059#discussion_r1990026247
##########
python/tests/test_wrapper_coverage.py:
##########
@@ -34,9 +34,15 @@ def missing_exports(internal_obj, wrapped_obj) -> None:
return
for attr in dir(internal_obj):
- if attr in ["_global_ctx"]:
+ # Skip internal context and RawExpr (which is handled by Expr class)
+ if attr in ["_global_ctx", "RawExpr"]:
+ continue
+
+ # Check if RawExpr functionality is covered by Expr class
+ if attr == "RawExpr" and hasattr(wrapped_obj, "Expr"):
+ expr_class = getattr(wrapped_obj, "Expr")
+ assert hasattr(expr_class, "raw_expr"), "Expr class must provide
raw_expr property"
Review Comment:
Instead of special casing it like this, we should be able to write a more
general solution that checks all class names. For the internal representation
they can begin with `Raw` and be converted to their non-raw counterparts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
