timsaucer commented on PR #1059:
URL: 
https://github.com/apache/datafusion-python/pull/1059#issuecomment-2715229161

   > I'll be renaming all the classes in `_internal` here:
   
   You'll want to get the submodules as well.
   
   Also, this can be done piecemeal if doing the entire thing in one go is too 
large a PR.
   
   The CI failure is the one I expected. We will need to update the check for 
export coverage in the wrappers to have this specific naming convention. 
Ideally, we would even require the `Raw` prefix once all of the classes are 
complete. But to manage the work, it likely makes sense to first get in one PR 
with the `RawExpr` handled and CI working, then iterate through the remaining 
classes, then update the CI check to require the `Raw` prefix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to