mvzink commented on code in PR #1747: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1747#discussion_r1987586710
########## src/ast/dml.rs: ########## @@ -138,6 +143,30 @@ pub struct CreateTable { pub engine: Option<TableEngine>, pub comment: Option<CommentDef>, pub auto_increment_offset: Option<u32>, + pub key_block_size: Option<u32>, Review Comment: Seems like a reasonable approach to me. Thanks for pushing this forward! I would suggest that whatever parsing routine/subparser produces that vector of options be written in such a way that it could be used for `ALTER TABLE` parsing as well; I believe their syntax is basically the same, at least for MySQL, and that struct should be updated as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org