tomershaniii commented on code in PR #1747: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1747#discussion_r1994029252
########## src/ast/helpers/stmt_create_table.rs: ########## @@ -78,25 +79,22 @@ pub struct CreateTableBuilder { pub hive_formats: Option<HiveFormat>, pub table_properties: Vec<SqlOption>, pub with_options: Vec<SqlOption>, + pub options: Option<Vec<SqlOption>>, + pub plain_options: Vec<SqlOption>, pub file_format: Option<FileFormat>, pub location: Option<String>, pub query: Option<Box<Query>>, pub without_rowid: bool, pub like: Option<ObjectName>, pub clone: Option<ObjectName>, - pub engine: Option<TableEngine>, pub comment: Option<CommentDef>, Review Comment: Good idea, will do -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org