tomershaniii commented on code in PR #1747:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1747#discussion_r1986746865
##########
src/ast/dml.rs:
##########
@@ -138,6 +143,30 @@ pub struct CreateTable {
pub engine: Option<TableEngine>,
pub comment: Option<CommentDef>,
pub auto_increment_offset: Option<u32>,
+ pub key_block_size: Option<u32>,
Review Comment:
I will be taking over this PR, diving into this suggestion:
Currently the `CreateTable` struct has a few types of options which are
AFAIU mainly dialect driven:
- with_options is formatted as "WITH (....options...)" -> Postgres & other
- options which is formatted as "OPTIONS (....options...)" -> BigQuery
- table_properties which is formatted as "TBLPROPERTIES (....options...)"
-> Databricks
Proposed design to support the [mysql
variant](https://dev.mysql.com/doc/refman/8.4/en/create-table.html):
- Add another parameter Vec which will include properties which do not
require a preceding keyword (WITH/OPTIONS/...), e.g. plain_options
- The Vec will include optional parameters which are currently assigned to
the `CreateTable` struct, e.g. engine / collation / ...
- Parameter parsing will be delegated to the respective Dialect to avoid
clutter in the main flow
@iffyio @mvzink your feedback is appreciated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
