mvzink commented on code in PR #1747: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1747#discussion_r1995867380
########## src/parser/mod.rs: ########## @@ -6928,13 +6874,122 @@ impl<'a> Parser<'a> { }; } + let plain_options = self.parse_plain_options()?; + Ok(CreateTableConfiguration { partition_by, cluster_by, options, + plain_options, }) } + fn parse_plain_option(&mut self) -> Result<Option<SqlOption>, ParserError> { + if let Some(option) = self.dialect.parse_plain_option(self)? { + return Ok(Some(option)); + } + + // Parse table options in any order + if let Some(keyword) = self.parse_one_of_keywords(&[ + Keyword::ENGINE, + Keyword::AUTO_INCREMENT, + Keyword::DEFAULT, + Keyword::CHARSET, + Keyword::COLLATE, + Keyword::INSERT_METHOD, + ]) { + let _ = self.consume_token(&Token::Eq); + let value = self.next_token(); + + match (keyword, value.token) { + (Keyword::AUTO_INCREMENT, Token::Number(n, l)) => { Review Comment: Nope, I totally missed that! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org