wiedld commented on PR #14821: URL: https://github.com/apache/datafusion/pull/14821#issuecomment-2691278923
> I'm a bit confused about what are we trying to solve and how. Could you @wiedld tell me which issue or reproducer we are trying to solve in this collection of PR's please? I'd like to unblock you but unsure how to do it We are trying to fix the coalesce bug. In the process, I've been adding docs and making small improvements to make the code easier to understand. > I'm still seeing the output_ordering() change which adds the heterogenous constant to the output_ordering, and I have said that doesn't seem correct to me. I've already removed this change. > What is the goal of this PR? The goal is to make the enforce sorting optimizer easier to understand, with this PR focused on the `pushdown_sorts` subrule. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org