berkaysynnada commented on PR #14821: URL: https://github.com/apache/datafusion/pull/14821#issuecomment-2690282648
> The equivalence properties' ordering methods, as well as the `add_sort_above` util method, were checking if the field was a constant -- and not considering if it's a heterogeneous constant. This commit [4775354](https://github.com/apache/datafusion/commit/47753541bdd1322f610b9ae72e922037d2999a12) makes the tests pass; is it the correct fix? > > Do you need me to make that^^ added commit into a separate PR? I'm still seeing the output_ordering() change which adds the heterogenous constant to the output_ordering, and I have said that doesn't seem correct to me. Did you mean to point out another part in that commit? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
