wiedld commented on PR #14821: URL: https://github.com/apache/datafusion/pull/14821#issuecomment-2689593652
Thanks for giving me time to catch up. After digging more into the ordering calculation, and making [a small PR](https://github.com/apache/datafusion/pull/14923) with additional test cases (to demonstrate how I think its intended to work?), I now agree with @berkaysynnada. I'm going to undo the ordering calculation change (revert that single commit). Instead, I'm pushing up a [temporary commit](https://github.com/apache/datafusion/pull/14821/commits/2ee747f87b1abc2c94f13f793a5b2879e6c37197) to show what test cases have a selective removal of the `order by count`. I'm not sure why the count field is only a constant when we have `Plain(unbounded) + no partition_by + on unordered column`. Keeping as a draft, and I'll dig more tmrw. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
