AdamGS commented on issue #14444: URL: https://github.com/apache/datafusion/issues/14444#issuecomment-2687434700
Just updating that seems like steps 2 and 3 need to happen in one PR, otherwise a lot of code will move around multiple times which seems like unnecessary noise. Another issue I've run into is that `ListingTable` (as well as csv, JSON and parquet) all downcast the session into a `SessionState` (see earlier discussions in #11600), which is currently core. The only functionality they want is `SessionState::default_table_options` and `SessionState::default_table_options`, so the easiest thing to do will be to just move those functions to the trait. Given the amount of conversations/issues I've found about this point, I think its best to get a second opinion here before I start moving things around. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
