alamb commented on issue #14444: URL: https://github.com/apache/datafusion/issues/14444#issuecomment-2676876878
> I'll try and take a stab at it, [@alamb](https://github.com/alamb) do you have a preference as to how many PRs I should break it into? There are no logical changes but I expect a very large numbers of small changes and would I love to do it in a way that you and others will be happy to review. > > edit: Started moving things around and seems like there a bunch of dependencies between them. I'll keep going until I get something that makes sense, hopefully the resulting PR won't be too big. Thank you @AdamGS -- that is super helpful In general, fewer smaller PRs is far easier to review. Also PRs that are mostly mechanical are also easy / fast to review PRs that make changes that might have larger downstream implications are harder / take longer (as they require finding more focused time to review them) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
