alamb commented on issue #14444: URL: https://github.com/apache/datafusion/issues/14444#issuecomment-2676188953
> > [@logan-keede](https://github.com/logan-keede) as part of moving avro functionality into `datafusion-datasource-avro`, WDYT about putting all of it behind a feature flag, the same way `parquet` is now? Seems like its the only format/source that is visible with `default-features = false` but panics at runtime (for example in `AvroSource::create_file_opener`) > > I do not have much context on why it has been kept this way, but here is what _I_ think > > It seems like you can currently make a new `AvroSource` but not read an existing file. There might be some limited use case where user only needed to simulate `AvroSource` for some reason. (even that might crash as some other functionalities also panic). I think this use case is very limited and unintuitive and it is better to have it behind a feature flag(as you suggested), even if it is an API-Change. > > TL;DR: I think we can do that, but it seems like an API change so deprecation first. > > [@alamb](https://github.com/alamb) WDYT? I think putting the entire AvroExec behind a feature flag makes sense even if it is an API change. I don't think we have to go through deprecation first as the change will be "add the flag" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
