logan-keede commented on issue #14444: URL: https://github.com/apache/datafusion/issues/14444#issuecomment-2690796829
> I have a first version that seems to pass all tests/clippy, but I'm left with one issue before I publish it. In order to keep the tests in the format-specific crates, I pulled `core` as a dev-dependency using a `path`, so it can still be published. Fixing `depcheck` to accept that is trivial, but I would love to know if that's an acceptable solution here or if I should move all tests up back to `core` where it has access to everything they need. referring to https://github.com/apache/datafusion/pull/14671#issuecomment-2660990592 and the fact that no crate has a dev-dependency on a crate above them in dependency tree (atleast none that I know of). I think it is acceptable but not encouraged. you may want to wait for a reply from @alamb or somebody else knowledgeable if you want to be sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
