Blizzara commented on code in PR #14860:
URL: https://github.com/apache/datafusion/pull/14860#discussion_r1969502677
##########
datafusion/substrait/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -308,6 +308,17 @@ async fn aggregate_grouping_rollup() -> Result<()> {
).await
}
+#[tokio::test]
+async fn multilayer_aggregate() -> Result<()> {
+ assert_expected_plan(
+ "SELECT a, sum(partial_count_b) FROM (SELECT a, count(b) as
partial_count_b FROM data GROUP BY a) GROUP BY a",
Review Comment:
I'm still a bit confused by this. Why does the original plan created from
SQL already contain the implicit groupBy's here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
