Blizzara commented on code in PR #14553:
URL: https://github.com/apache/datafusion/pull/14553#discussion_r1954759741
##########
datafusion/substrait/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -300,6 +300,17 @@ async fn aggregate_grouping_rollup() -> Result<()> {
).await
}
+#[tokio::test]
+async fn multilayer_aggregate() -> Result<()> {
Review Comment:
Ah, so the SQL -> Logical plan _doesn't_ add the extra grouping expressions?
Then it feels even more wrong that the LogicalPlanBuilder::aggregate does, but
I guess that's a separate discussion 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
