alamb commented on code in PR #14860:
URL: https://github.com/apache/datafusion/pull/14860#discussion_r1968445509
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -63,6 +64,32 @@ use indexmap::IndexSet;
/// Default table name for unnamed table
pub const UNNAMED_TABLE: &str = "?table?";
+#[derive(Debug, Clone)]
+pub struct LogicalPlanBuilderOptions {
+ /// Flag indicating whether the plan builder should add
+ /// functionally dependent expressions as additional aggregation groupings.
+ add_implicit_group_by_exprs: bool,
+}
+
+impl Default for LogicalPlanBuilderOptions {
+ fn default() -> Self {
+ Self {
+ add_implicit_group_by_exprs: false,
+ }
+ }
+}
+
+impl LogicalPlanBuilderOptions {
+ pub fn new() -> Self {
+ Default::default()
+ }
+
+ pub fn with_add_implicit_group_by_exprs(mut self, add: bool) -> Self {
Review Comment:
```suggestion
/// Should the builder add functionally dependent expressions as
additional aggregation groupings.
pub fn with_add_implicit_group_by_exprs(mut self, add: bool) -> Self {
```
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -63,6 +64,32 @@ use indexmap::IndexSet;
/// Default table name for unnamed table
pub const UNNAMED_TABLE: &str = "?table?";
+#[derive(Debug, Clone)]
Review Comment:
```suggestion
/// Options for [`LogicalPlanBuilder`]
#[derive(Debug, Clone)]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
