anlinc commented on code in PR #14553:
URL: https://github.com/apache/datafusion/pull/14553#discussion_r1960628552
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -1089,12 +1089,33 @@ impl LogicalPlanBuilder {
self,
group_expr: impl IntoIterator<Item = impl Into<Expr>>,
aggr_expr: impl IntoIterator<Item = impl Into<Expr>>,
+ ) -> Result<Self> {
+ self.aggregate_inner(group_expr, aggr_expr, true)
+ }
+
+ pub fn aggregate_without_implicit_group_by_exprs(
Review Comment:
I'm taking a look now!
It does indeed make sense to have this disabled by default, and enabled only
on the SQL path.
I also want to experiment with @Blizzara's suggestion -- we could inline the
additional expressions change on the SQL plan path instead. Part of why we may
not want a variable is:
* It really only applies to one construct in the builder (aggregations).
* It's probably not a popular configuration to use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
