parthchandra commented on code in PR #1359:
URL: https://github.com/apache/datafusion-comet/pull/1359#discussion_r1939760671
##########
native/core/src/execution/planner.rs:
##########
@@ -1155,12 +1154,9 @@ impl PhysicalPlanner {
))
});
- let object_store = object_store::local::LocalFileSystem::new();
- // register the object store with the runtime environment
- let url = Url::try_from("file://").unwrap();
- self.session_ctx
- .runtime_env()
- .register_object_store(&url, Arc::new(object_store));
+ // By default, local FS object store registered
+ // if `hdfs` feature enabled then HDFS file object store
registered
+ let object_store_url =
register_object_store(Arc::clone(&self.session_ctx))?;
Review Comment:
Should we update this function
([get_file_path](https://github.com/apache/datafusion-comet/blob/996362e78d497c02542f1e29dbb7cba3ec16f64c/native/core/src/parquet/util/jni.rs#L214C8-L214C21))
as well?
It's currently used by `NATIVE_ICEBERG_COMPAT` but the goal is to unify it
with `COMET_DATAFUSION`.
##########
Makefile:
##########
@@ -95,7 +98,7 @@ release-linux: clean
cd native && RUSTFLAGS="-Ctarget-cpu=native
-Ctarget-feature=-prefer-256-bit" cargo build --release
./mvnw install -Prelease -DskipTests $(PROFILES)
release:
- cd native && RUSTFLAGS="-Ctarget-cpu=native" cargo build --release
+ cd native && RUSTFLAGS="$(RUSTFLAGS) -Ctarget-cpu=native" &&
RUSTFLAGS=$$RUSTFLAGS cargo build --release $(FEATURES_ARG)
Review Comment:
`$$RUSTFLAGS` ? Never seen this pattern before. What does this do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
