comphead commented on code in PR #1359:
URL: https://github.com/apache/datafusion-comet/pull/1359#discussion_r1939824736
##########
native/core/src/execution/planner.rs:
##########
@@ -1155,12 +1154,9 @@ impl PhysicalPlanner {
))
});
- let object_store = object_store::local::LocalFileSystem::new();
- // register the object store with the runtime environment
- let url = Url::try_from("file://").unwrap();
- self.session_ctx
- .runtime_env()
- .register_object_store(&url, Arc::new(object_store));
+ // By default, local FS object store registered
+ // if `hdfs` feature enabled then HDFS file object store
registered
+ let object_store_url =
register_object_store(Arc::clone(&self.session_ctx))?;
Review Comment:
Thats a good point, to verify it we probably need to read Iceberg from HDFS
which can be done in #1367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
