findepi commented on PR #14273: URL: https://github.com/apache/datafusion/pull/14273#issuecomment-2621162538
I am OK having DF coercions extensible (https://github.com/apache/datafusion/issues/14296), but first and foremost I want them to be **_optional_**. At ~SDF~ dbt, we create fully resolved and coerced plans, and so DF's coercion rules cannot do any good. For our needs the best would be clear separation of SQL analysis layer, where coercions should exist, and formal plan processing layer, where coercions should no longer exist. This was outlined in https://github.com/apache/datafusion/issues/12723. Regardless of future apt plans and potential customizability via new or existing extension points, we need to decide what is the "out of the box" behavior. We have a rule to follow PostgreSQL in principle and this is what this PR does. I consider it non-controversial. The existing comments revolve our "let's make sure it's properly reviewed" and by now it's obviously is. Will merge tomorrow unless there are actionable objections. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
