findepi commented on PR #14273: URL: https://github.com/apache/datafusion/pull/14273#issuecomment-2613421578
@alamb thanks for your feedback. I agree it's important to avoid back-and-forth with a change, so the broader review the better. > What the current coercion behavior is https://github.com/apache/datafusion/issues/14272 > What we want it to be (and why we want to change it) I don't think this particular change should be controversial though. See issue, but also: 1. we as the project primarily follow PostreSQL behavior and this is what this PR does (i think this rule is kind of well established, even if not well documented, but i see https://github.com/apache/datafusion/pull/13706 is not merged) 2. PostgreSQL aside, the implicit coercions should generally not fail (but alas, i've seen systems violating this common sense rule). Casting from float to decimal obviously may mail > Get agreement on to goal let's do it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
