andygrove commented on PR #14273: URL: https://github.com/apache/datafusion/pull/14273#issuecomment-2625058104
Thanks for the pings. I agree with not rushing this in. Decimals are exact types and floats are not so we need to be careful. There was an earlier issue where we used float instead of decimal in some places and it resulted in correctness issues. I will run the Comet/Spark tests with these changes and see what happens. +1 for user-defined coercion rules as well though, separate to this discussion. In Comet we want to use coercion rules that match Spark behavior. We do currently use some of DataFusion's coercion rules. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
