alamb commented on code in PR #14273:
URL: https://github.com/apache/datafusion/pull/14273#discussion_r1929723752


##########
datafusion/core/tests/parquet/mod.rs:
##########
@@ -184,7 +184,13 @@ impl TestOutput {
 /// and the appropriate scenario
 impl ContextWithParquet {
     async fn new(scenario: Scenario, unit: Unit) -> Self {
-        Self::with_config(scenario, unit, SessionConfig::new()).await
+        let mut session_config = SessionConfig::new();
+        // TODO (https://github.com/apache/datafusion/issues/12817) once this 
is the default behavior, remove from here

Review Comment:
   Does this means that DataFusion will no longer prune predicates like 
`decimal_col = 5.0`?
   
   If so, this likely a significant regression / issue for anyone who relies on 
decimal types (like comet for example)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to