Rachelint commented on PR #14301: URL: https://github.com/apache/datafusion/pull/14301#issuecomment-2614410525
> > I think an alternative to this can be to divide this PR into increments and keep a aggregate_supplement.slt file and initially it will be same as aggregate.slt but as we move out queries we subtract them from the supplement file only. This way even if we there is some query that is left in supplement we can just move it later when it is discovered by using reference from original. (We can always find it in commit history but that's a bit inconvenient > > @logan-keede it is said that still one pr, but we perform `extract and subtract` for a specific function in one commit, and then we check it between commits? > > It seems workable too, but actullay a bit inconvenient to check if large changes in one pr? > > And for the extract and subtract approach, I think it seems really good. Or I misunderstand? We will split it into multiple prs and we perform `extract and subtract` for a specific function in one pr? I think we may be on the same page if it means that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
