Rachelint commented on code in PR #14301: URL: https://github.com/apache/datafusion/pull/14301#discussion_r1929703073
########## datafusion/sqllogictest/test_files/aggregate/string.slt: ########## Review Comment: Seems switching to use data type to split rather than function? ########## datafusion/sqllogictest/test_files/aggregate/aggregate.slt: ########## @@ -0,0 +1,3053 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at + +# http://www.apache.org/licenses/LICENSE-2.0 + +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +####### +# Setup test data table +####### +include ./init.slt.part + +# FIX: custom absolute values +# csv_query_avg_multi_batch + +# csv_query_avg +query R +SELECT avg(c12) FROM aggregate_test_100 +---- +0.508972509913 + +# csv_query_bit_and +query IIIII +SELECT bit_and(c5), bit_and(c6), bit_and(c7), bit_and(c8), bit_and(c9) FROM aggregate_test_100 +---- +0 0 0 0 0 + +# csv_query_bit_and_distinct +query IIIII +SELECT bit_and(distinct c5), bit_and(distinct c6), bit_and(distinct c7), bit_and(distinct c8), bit_and(distinct c9) FROM aggregate_test_100 Review Comment: It seems a part of `bit_and_or_xor`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
