Rachelint commented on PR #14301: URL: https://github.com/apache/datafusion/pull/14301#issuecomment-2614315536
> Main thing I am worried about is that this pr seems too large, it seems hard to ensure all exists testcases are moved rightly. Maybe we can push it forward more incrementally? I have some thoughts about it: > > * Only extract the common part(mainly table creatings, e.g. `aggregate_test_100`, `d_table`, `test`...), and the files structure after extracting may be: > > > ``` > -- aggregate > -- init_data.slt.part > -- aggregate.slt > ``` > > * Sort the cases in `aggregate.slt` using comments firstly before moving to a specific `slt`, and think a way to ensure no cases are lost(I can help this step). It may be like: > > > ``` > aggregate.slt > > ####### > # Count tests > ####### > ... > > ####### > # Sum tests > ####### > ... > > ####### > # Min/Max tests > ####### > ... > ``` > > * Move and split the testcases to specific `slt`s. > > > ``` > -- aggregate > -- init_data.slt.part > -- aggregate.slt (cases difficult to classify, or still waiting to be moved in following prs) > -- count.slt > -- sum.slt > -- min/max.slt > ... > ``` And how about we just start from the first step in this pr? And continue pushing it forward in following prs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
