logan-keede commented on code in PR #14301: URL: https://github.com/apache/datafusion/pull/14301#discussion_r1929767728
########## datafusion/sqllogictest/test_files/aggregate/string.slt: ########## Review Comment: `aggregate.slt` already had loose subsections for eg. most of the tests in `date_time.slt` are made to work together(because of mix of different functions) + there is a section for postgres dialect only somewhere in original file. I doubt there would be much confusing tests left after that and we can just put them in both files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
