logan-keede commented on PR #14301: URL: https://github.com/apache/datafusion/pull/14301#issuecomment-2614334330
> * Sort the cases in `aggregate.slt` using comments firstly before moving to a specific `slt`, and think a way to ensure no cases are lost(I can help this step). It may be like: I think an alternative to this can be to divide this PR into increments and keep a `aggregate_supplement.slt` file and initially it will be same as `aggregate.slt` but as we move out queries we subtract them from the supplement file only. This way even if we there is some query that is left in `supplement` we can just move it later when it is discovered by using reference from original. (We can always find it in commit history but that's a bit inconvenient) dejavu > It seems a part of `bit_and_or_xor`? I say this because this sorting might become a huge PR by itself, this approach divides this sorting into increments with PRs. This is kind of what I am doing but in a more incremental manner with added redundancy. @Rachelint Let me know if you think this is a bad Idea. I will open a new PR once we are on the same page. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
