mbutrovich commented on code in PR #1192:
URL: https://github.com/apache/datafusion-comet/pull/1192#discussion_r1901279652
##########
native/core/src/execution/shuffle/shuffle_writer.rs:
##########
@@ -1570,13 +1588,41 @@ pub fn write_ipc_compressed<W: Write + Seek>(
// write ipc_length placeholder
output.write_all(&[0u8; 8])?;
Review Comment:
I know this isn't your code, but it jumped out at me: can we replace this
8-byte write with a seek?
```
// seek past ipc_length placeholder
output.seek_relative(8)?;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
